Display person use count for project in author match #4943

Author: kleintom

CHANGELOG.md

@@ -14,6 +14,7 @@ This project <em>does not yet</em> adhere to [Semantic Versioning](https://semve
 - CSD: Added a button to load the associated CO when the identifier is already in use by another CO
 - Ctrl+v to paste images and documents in "Drop [image/doc] here"
 - New descriptors: character states' thumbnails [#4796]
+- Project usage count for authors in Match Author task of New Source [#4943]
 
 ### Changed
 
@@ -41,6 +42,7 @@ This project <em>does not yet</em> adhere to [Semantic Versioning](https://semve
 [#4928]: https://github.com/SpeciesFileGroup/taxonworks/issues/4928
 [#4929]: https://github.com/SpeciesFileGroup/taxonworks/issues/4929
 [#4932]: https://github.com/SpeciesFileGroup/taxonworks/issues/4932
+[#4943]: https://github.com/SpeciesFileGroup/taxonworks/issues/4943
 [#4946]: https://github.com/SpeciesFileGroup/taxonworks/issues/4946
 [#4959]: https://github.com/SpeciesFileGroup/taxonworks/issues/4959
 

app/controllers/people_controller.rb

@@ -126,8 +126,7 @@ def author_match
     people = Queries::Person::Filter.new(author_match_params).all.to_a
 
     @people = Utilities::PersonNameMatch.sort_by_match(people, first_name, last_name)
-
-    render :index
+    @project_use_counts = Person.project_use_counts(@people.map(&:id), sessions_current_project_id)
   end
 
   # GET /people/download

app/javascript/vue/tasks/sources/new_source/components/bibtex/AuthorMatchModal.vue

@@ -84,6 +84,10 @@
                       x-small
                     />
                   </a>
+                  <span
+                    class="use-count"
+                    :title="`${person.use_count} project ${person.use_count === 1 ? 'use' : 'uses'}`"
+                  >{{ person.use_count }} {{ person.use_count === 1 ? 'use' : 'uses' }}</span>
                 </div>
               </div>
               <div
@@ -371,16 +375,31 @@ async function searchMatches(row, claimedRoleIds) {
     }
   }
 
+  // Preserves the backend's name-group order (e.g. exact matches before fuzzy),
+  // but within each group of identically-named people sorts by project use count descending.
+  const sortByUsage = (matches) => {
+    const groupOrder = {}
+    matches.forEach((p) => {
+      const key = p.cached || p.name || ''
+      if (!(key in groupOrder)) groupOrder[key] = Object.keys(groupOrder).length
+    })
+    return [...matches].sort((a, b) => {
+      const groupDiff = groupOrder[a.cached || a.name || ''] - groupOrder[b.cached || b.name || '']
+      if (groupDiff !== 0) return groupDiff
+      return (b.use_count || 0) - (a.use_count || 0)
+    })
+  }
+
   const handleResult = (people) => {
     if (!firstReturned) {
       firstReturned = true
-      row.matches = people
+      row.matches = sortByUsage(people)
       row.isSearching = false
       claimExistingRole(people)
     } else {
       const existingIds = new Set(row.matches.map((p) => p.id))
       const incoming = people.filter((p) => !existingIds.has(p.id))
-      row.matches = [...row.matches, ...incoming]
+      row.matches = sortByUsage([...row.matches, ...incoming])
       row.isFuzzySearchPending = false
       claimExistingRole(incoming)
     }
@@ -500,6 +519,11 @@ td {
   font-size: 0.85em;
 }
 
+.use-count {
+  font-size: 0.8em;
+  color: var(--text-muted-color);
+}
+
 .create-cell {
   min-width: 250px;
 }

app/models/person.rb

@@ -440,6 +440,28 @@ def is_collector?
     collector_roles.any?
   end
 
+  # @param [Array] person_ids
+  # @param [Integer] project_id
+  # @return [Hash]
+  #   person_id => count of in-project roles (direct + via project sources)
+  def self.project_use_counts(person_ids, project_id)
+    return {} if person_ids.empty?
+
+    direct = Role.where(person_id: person_ids, project_id:)
+      .group(:person_id).count
+
+    via_source = Role
+      .where(person_id: person_ids, project_id: nil)
+      .joins("JOIN sources ON roles.role_object_id = sources.id AND roles.role_object_type = 'Source'")
+      .joins('JOIN project_sources ON sources.id = project_sources.source_id')
+      .where(project_sources: { project_id: })
+      .group(:person_id).count
+
+    (direct.keys | via_source.keys).index_with do |id|
+      (direct[id] || 0) + (via_source[id] || 0)
+    end
+  end
+
   def role_counts(project_id)
     {
       in_project: self.roles.where(project_id:).group(:type).count,

app/views/people/author_match.json.jbuilder

@@ -0,0 +1,4 @@
+json.array!(@people) do |person|
+  json.partial! '/people/base_attributes', person: person
+  json.use_count @project_use_counts[person.id] || 0
+end