Skip to content

Resolved issue #2971#2989

Merged
Timer merged 3 commits into
react:masterfrom
davejsdev:issue-#2971
Sep 13, 2017
Merged

Resolved issue #2971#2989
Timer merged 3 commits into
react:masterfrom
davejsdev:issue-#2971

Conversation

@davejsdev

@davejsdev davejsdev commented Aug 21, 2017

Copy link
Copy Markdown
  • Changed h2 to h1 in template to adhere to accessibility guidelines.
  • Added h1 styles to maintain same font size.
  • Changed div tag to the semantically correct header tag for header in template.

Verification of changes:

  1. Created new React app using the modified branch.
  2. Checked code to ensure the h2 tag has been replaced with the h1 tag.
  3. Ran npm start and verified the font size of new h1 tag matches the former h2 tag in browser.

Loading
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants