Properly return 403 for Forbidden#1555
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1555 +/- ##
==========================================
- Coverage 77.04% 77.03% -0.02%
==========================================
Files 611 611
Lines 45995 46000 +5
Branches 800 800
==========================================
- Hits 35437 35436 -1
- Misses 10471 10476 +5
- Partials 87 88 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jmthomas
left a comment
jmthomas
left a comment
There was a problem hiding this comment.
Nice job fixing that stream_log_spec!
| raise AuthError.new("Token is required") unless token | ||
| unless OpenC3::AuthModel.verify(token) | ||
| raise AuthError.new("Password is invalid for '#{permission}' permission") | ||
| raise AuthError.new("Password is invalid") |
There was a problem hiding this comment.
Was this removed just because it was leaking unnecessary info?
| PARAMETER CCSDSTYPE 3 1 UINT 1 1 1 "CCSDS primary header packet type" | ||
| PARAMETER CCSDSSHF 4 1 UINT 0 0 0 "CCSDS primary header secondary header flag" | ||
| ID_PARAMETER CCSDSAPID 5 11 UINT 0 2047 999 "CCSDS primary header application id" | ||
| ID_PARAMETER CCSDSAPID 5 11 UINT 0 2047 <%= id %> "CCSDS primary header application id" |
There was a problem hiding this comment.
It's weird that we hard coded this in the demo but the PKTID was always covering it. If you're going to do it here you should do it in INST as well.
|
2 participants
No description provided.