Skip to content

Change cmd keyword from validator to validate#1574

Merged
jmthomas merged 1 commit into
mainfrom
validate
Sep 26, 2024
Merged

Change cmd keyword from validator to validate#1574
jmthomas merged 1 commit into
mainfrom
validate

Conversation

@jmthomas

@jmthomas jmthomas commented Sep 26, 2024

Copy link
Copy Markdown
Member

The validator is the thing you set but the command reads better as validate true / false I think. This also adds the keyword to the script api.

@jmthomas jmthomas requested a review from ryanmelt September 26, 2024 03:07
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@codecov

codecov Bot commented Sep 26, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.03%. Comparing base (ebc6cbf) to head (26976e1).
Report is 16 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1574   +/-   ##
=======================================
  Coverage   77.03%   77.03%           
=======================================
  Files         613      613           
  Lines       46046    46051    +5     
  Branches      802      802           
=======================================
+ Hits        35471    35477    +6     
+ Misses      10487    10486    -1     
  Partials       88       88           
Flag Coverage Δ
frontend 55.67% <ø> (-0.04%) ⬇️
python 84.63% <ø> (+0.03%) ⬆️
ruby-api 49.01% <ø> (ø)
ruby-backend 82.82% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmthomas jmthomas merged commit cda01ab into main Sep 26, 2024
@jmthomas jmthomas deleted the validate branch September 26, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants