Suppress final live render for non-interactive output#4153
Open
praneetware wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #3040
Description
This draft PR explores a possible fix for issue #3040 ("Interactive progress bars are being written to files").
Reproduction
Using the following example:
and redirecting stdout:
python repro.py > output.txtthe resulting file contains:
Investigation
While investigating, I found that
Live.process_renderables()explicitly renders the final live output for non-interactive outputs:The documentation states that Rich removes animations such as progress bars when not writing to a terminal, so I wanted to explore whether the final rendered progress output should also be suppressed.
Change
This draft removes the final live render for non-interactive outputs, which prevents progress bars from being written to redirected output files.
Notes
This is submitted as a draft PR to gather feedback on the intended behavior before adding tests or making further changes.