Add support for expiry date in ignore#3481
Open
laurentb4 wants to merge 1 commit into
Open
Conversation
Signed-off-by: lauren_tb <lauren.taylor-brown@justice.gov.uk>
c3191f0 to
55771f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds support for an
expires-afterfield to ignore rules, allowing users to specify a date after which an ignore rule will no longer apply. It includes validation, logic changes, and tests to ensure correct handling of the new field.Motivation
Currently the .grype.yml file does does not support the inclusion of an expiry date for vulnerabilities that are intentionally ignored.
Changes
expires-afterfield to theIgnoreRulestruct, allowing users to set an expiration date for ignore rules. The rule will be ignored if the current date is after the specified date. [1] [2]parseExpiresAfterandisExpiresAfterInPastto parse and evaluate the expiration date, handling empty and malformed values gracefully.IgnoreRule.IgnoreMatchmethod to skip rules whose expiration date has passed.Validation and Testing
Validatemethod toIgnoreRuleto check for malformedexpires-aftervalues at config load time, providing early feedback to users.ignore_test.goto cover various scenarios for theexpires-afterfield, including valid, empty, past, future, and malformed dates.Miscellaneous
Type of change
Checklist