GH-43010: [C++][Compute] Support view arrays in selection kernels#50164
Open
Periecle wants to merge 1 commit into
Open
GH-43010: [C++][Compute] Support view arrays in selection kernels#50164Periecle wants to merge 1 commit into
Periecle wants to merge 1 commit into
Conversation
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
6 tasks
fce680d to
0b590c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
binary_viewandstring_viewarrays were not fully supported by selection kernels. This also blocked dictionary decoding for dictionaries with view-type values.What changes are included in this PR?
BINARY_VIEWandSTRING_VIEW.Are these changes tested?
Yes.
pre-commit run cpp --files <changed files>cmake --build cpp/build --target arrow-compute-vector-selection-testAre there any user-facing changes?
Yes.
binary_viewandstring_viewarrays are now supported by the affected selection and dictionary decode paths.Partially addresses GH-39634
Closes GH-43010