fix: honor kbagent action retry policy#10361
Draft
weicao wants to merge 1 commit into
Draft
Conversation
Collaborator
|
Auto Cherry-pick Instructions CLA Recheck Instructions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Redis reconfigure validation found that lifecycle actions needing bounded wait can be killed before convergence even when the addon declares a larger timeout:
timeoutSeconds: 120is capped by kbagent at 60 seconds.retryPolicydeclared on the action is registered into the kbagent action table, but the action service only usedreq.RetryPolicywhen executing the action.ReconfigureArgs, but not a request-level retry policy, so an action-levelretryPolicyis ineffective on this path.This makes the addon-side pattern
exit non-zero + retryPolicyunreliable for reconfigure actions.Solution
maxActionCallTimeoutfrom 60s to 120s and update the public Action timeout docs.Validation
Local validation passed:
Additional test note:
go test ./pkg/controller/component -count=1could not run on this machine because envtest assets are missing:/usr/local/kubebuilder/bin/etcdnot found. The package did not reach product assertions.Boundary
This PR is a controller/kbagent candidate for the Redis task #46 timeout/retry gap. It still needs exact-image runtime validation on the affected reconfigure scenario before being treated as test-accepted or ready for non-draft review.