fix: gRPC Monitor call does not emit applied_settings response#3191
Merged
Conversation
2dab057 to
73c3b5f
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3191 +/- ##
=======================================
Coverage 69.48% 69.48%
=======================================
Files 252 252
Lines 19557 19585 +28
=======================================
+ Hits 13589 13609 +20
- Misses 4710 4713 +3
- Partials 1258 1263 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mirkoCrobu
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Fixes the problem described in detail in #2965
What is the current behavior?
The gRPC Monitor call does not emit
applied_settingsresponseWhat is the new behavior?
The gRPC Monitor call does emit
applied_settingsresponse, both after opening the port, and after applying changes.Does this PR introduce a breaking change, and is titled accordingly?
No
Other information
Fix #2965