Skip to content

fix: gRPC Monitor call does not emit applied_settings response#3191

Merged
cmaglie merged 3 commits into
arduino:masterfrom
cmaglie:fix_monitor_grpc_feedback
Jun 5, 2026
Merged

fix: gRPC Monitor call does not emit applied_settings response#3191
cmaglie merged 3 commits into
arduino:masterfrom
cmaglie:fix_monitor_grpc_feedback

Conversation

@cmaglie

@cmaglie cmaglie commented May 19, 2026

Copy link
Copy Markdown
Member

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Fixes the problem described in detail in #2965

What is the current behavior?

The gRPC Monitor call does not emit applied_settings response

What is the new behavior?

The gRPC Monitor call does emit applied_settings response, both after opening the port, and after applying changes.

Does this PR introduce a breaking change, and is titled accordingly?

No

Other information

Fix #2965

@cmaglie cmaglie self-assigned this May 19, 2026
@cmaglie cmaglie added type: imperfection Perceived defect in any part of project topic: gRPC Related to the gRPC interface labels May 19, 2026
@cmaglie cmaglie requested a review from a team May 19, 2026 16:41
@per1234 per1234 added the topic: code Related to content of the project itself label May 20, 2026
@cmaglie cmaglie force-pushed the fix_monitor_grpc_feedback branch from 2dab057 to 73c3b5f Compare May 30, 2026 15:12
@codecov

codecov Bot commented May 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 77.27273% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.48%. Comparing base (dd407d4) to head (73c3b5f).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
commands/service_monitor.go 77.27% 1 Missing and 4 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3191   +/-   ##
=======================================
  Coverage   69.48%   69.48%           
=======================================
  Files         252      252           
  Lines       19557    19585   +28     
=======================================
+ Hits        13589    13609   +20     
- Misses       4710     4713    +3     
- Partials     1258     1263    +5     
Flag Coverage Δ
unit 69.48% <77.27%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cmaglie cmaglie merged commit 92b5682 into arduino:master Jun 5, 2026
177 of 179 checks passed
@cmaglie cmaglie deleted the fix_monitor_grpc_feedback branch June 5, 2026 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: code Related to content of the project itself topic: gRPC Related to the gRPC interface type: imperfection Perceived defect in any part of project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[GRPC] Monitor does not emit applied_settings response after changing the baudrate

3 participants