Resolve more CSRF issues#1521
Merged
Merged
Conversation
20wildmanj
previously approved these changes
May 18, 2022
20wildmanj
left a comment
Contributor
There was a problem hiding this comment.
- Checked that all methods still work as intended (Disregarding issue with Tango functioning properly which is addressed in #1524)
- GET requests all return routing errors
- POST from cross-site causes authentication error
Added two minor comments but otherwise LGTM
Contributor
20wildmanj
approved these changes
May 19, 2022
20wildmanj
left a comment
Contributor
There was a problem hiding this comment.
Looks good now, functionality still works, GET fails + cross-site POST fails as well, so CSRF protection is working. Thanks for the changes as well to sudo, makes it easier to understand! Ready to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This PR serves to change
GETrequests toPOSTrequests where appropriate to preempt future CSRF attacks.Description
Changed the following routes to
POSTMotivation and Context
Using
GETincorrectly opens Autolab up to CSRF attacks. Changing the appropriate routes toPOSTprotects us against these attacks.How Has This Been Tested?
For each of the following, tested that
GETno longer works,POSTworks as expected, fudging token causes an errorhttp://localhost; connect account. Check revoke button in user profile page]Types of changes
Checklist:
overcommit --install && overcommit --signto use pre-commit hook for linting