Hide unreleased assessment attachments#1548
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
left_outer_joinin order to include attachments that belong to the course, since they will have anassessment_idofnil)Motivation and Context
Currently, released attachments of unreleased assessments are viewable to students (but not downloadable). While not a major issue, this is not desirable if e.g. the instructor wants to mark certain attachments as released ahead of time but does not want students to see their names.
Fixes #1527
How Has This Been Tested?
Created released and unreleased attachments for course, unreleased assessment (Homework 0), and released assessment (Homework 1). Student should only be able to see released attachments for course and Homework 1.
As instructor:

As student:

Types of changes
Checklist:
overcommit --install && overcommit --signto use pre-commit hook for lintingOther issues / help required
Unsure if syntax follows best practices.