Add course number#1637
Merged
Merged
Conversation
- Remove unused CSS - Fix left align for email cells - Add columns for course and lecture - Increase width for readability
najclark
requested changes
Nov 23, 2022
najclark
left a comment
Contributor
There was a problem hiding this comment.
All of the changes look good, however for users that are added via 'Import roster/users' the course number shows up in the import course roster table

(the row is black, because I re-imported the csv for the screenshot)
but it doesn't seem like the course number shows up with the student


Users added via the 'Add user to course' button do seem to have the course number.
najclark
approved these changes
Nov 23, 2022
najclark
left a comment
Contributor
There was a problem hiding this comment.
Looks good now, confirmed that users uploaded via 'import roster' had course number, and when uploading an updated csv, the change in course number was reflected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
add user to courseform to support course numberMisc
course average tweaksection ofadd user to course.tip)assessments_showinshow.html.erbMotivation and Context
Record course numbers for students, so that students from different courses but in the same autolab course can be distinguished.
How Has This Been Tested?
add user to courseform is able to correctly create user with course numberImport Autolab Format / CMU Roster Format
Autolab Format:
M22,xho@foo.bar,Ho,Damian,SCS,CS,2025,L,15122,1,ACMU Roster Format:
Semester,Course,Section,Lecture,Mini,Last Name,Preferred/First Name,MI,Andrew ID,Email,College,Department,Major,Class,Graduation Semester,Units,Grade Option,QPA Scale,Mid-Semester Grade,Primary Advisor,Final Grade,Default Grade,Time Zone Code,Time Zone Description,Added By,Added On,Confirmed,Waitlist Position,Units Carried/Max Units,Waitlisted By,Waitlisted On,Dropped By,Dropped On,Roster As Of DateM22,15122,A,1,N,Ho,Damian,,xho,xho@andrew.cmu.edu,SCS,CS,CS,3,F25,0,L,4+,,Test Advisor,,,EST,Eastern Standard Time (GMT-5:00),fake_andrewid,11 Jul 2022,Y,,,,,,,11 Jul 2022 12:00 AMImport error table

Autolab Format:
M22,bad@foo.bar,,,SCS,CS,2025,L,15122,1,ACourse number appears on gradebook / gradesheet / manage students / course profile




(Note: gradebook's email cells are now left-aligned as was intended, cells are also wider)
Add user to course form

Statistics by course

Types of changes
Checklist:
overcommit --install && overcommit --signto use pre-commit hook for linting