Fix codebox highlighting after switching files#1647
Merged
Conversation
20wildmanj
approved these changes
Nov 23, 2022
20wildmanj
left a comment
Contributor
There was a problem hiding this comment.
Change looks good to me, and verified that highlighting stays active after switching. I was unable to reproduce the original case of highlighting failing however, if possible could I get a more specific flow to break the highlighting?
Member
Author
Screen.Recording.2022-11-23.at.11.56.49.mov |
Contributor
|
Ah I see, was able to reproduce. All good to merge in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moved
#highlightLongLinesevent listener intoattachEventsfunction.Motivation and Context
Currently, the event listener for the "highlight lines longer than 80 characters" checkbox is only attached once on page load.
However, when switching files, the elements of the codebox is replaced, meaning that the listener no longer works.
This PR attaches the event listener inside the
attachEventsfunction instead, which is called onHow Has This Been Tested?
helloand the first line of the autograder output suffices)Types of changes
Checklist:
overcommit --install && overcommit --signto use pre-commit hook for linting