[WIP] LTI NRPS roster integration#1654
Closed
najclark wants to merge 52 commits into
Closed
Conversation
- fix error for no cuds for non-admin instructor
…uest via Client-Credentials Grant - Add lti_context_membership_url to course_user_data to store NRPS course membership url for NRPS requests - Add placehold frontend to initiate requests
- remove amount of parameters sent to users controller
…tform public key or fetch public JWKs from URL provided in lti_settings.yml - necessary because platform could be using multiple private keys to sign their JWTs, so we need to fetch all of their public keys to validate the JWT returned during launch - clean up lti_nrps_controller
…an-nrps # Conflicts: # app/controllers/courses_controller.rb # app/views/courses/users.html.erb
Contributor
Author
|
Closing this PR, updated PR here: #1657 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Builds on the Implement LTI Advantage NRPS GET request PR
Implements logic to take the NRPS membership data and updates the roster of a course.
Created new 'lti settings' modal.
How Has This Been Tested?
Going through the LTI linking instructions outlined in this PR
Navigate to 'Manage Course Users'
Click the refresh button
Verify that additional students have been added to the course.
Click 'Autolab Test Link Settings'
Check 'Auto drop students not enrolled on Autolab Test', then press 'Save'
Click the refresh button
Verify that the students that weren't added in the previous task are now marked as dropped
Click 'Autolab Test Link Settings'
Click 'unlink' and verify unlinking a course works as expected (i.e. 'Autolab Test Link Settings' should not appear on the 'Manage Course Users' page)
Types of changes
Checklist:
overcommit --install && overcommit --signto use pre-commit hook for linting