Correctly display orphaned annotations on viewFeedback page

[michellexliu]

Description

Previously, if you add an annotation for a problem, delete the problem, and go view feedback, there was an error caused by calling problem.name.

If the problem is nil, the header is updated to say "Deleted Problem(s)", to match how orphaned problems are handled in #1629.

The issue of annotations for deleted problems was fixed by #1629, but this prevents an error on the view feedback page for pages where a problem was deleted before the patch was implemented.

Also updated check so that instructors & course assistants can view annotations even if they're not released.

How Has This Been Tested?

• Tested with annotations for regular problems
• Added an annotation for a problem --> deleted the problem --> clicked view feedback

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• I have run rubocop for style check. If you haven't, run overcommit --install && overcommit --sign to use pre-commit hook for linting
• My change requires a change to the documentation, which is located at Autolab Docs
• I have updated the documentation accordingly, included in this PR

[damianhxy]

I would suggest making the following simple change to allow orphaned annotations to be deleted (and also edited, to change the problem):

Add the lines

# Associated problem was deleted
return if score.problem_id && score.problem.nil?

inside annotation.rb#update_non_autograded_score, after score = Score.find_or_initialize_by_submission_id_and_problem_id... and before return if score.grader_id == 0

We check for score.problem_id to be future-proof, in case we implement (problem-independent) global annotations that presumably will have no problem_id at all.

[damianhxy]

Verified that course assistants and instructors can now see annotations even when the problem is not released.

Also verified that orphaned annotations show up under Deleted Problem(s).

[damianhxy]

For consistency, could you also update getProblemNameWithId in annotations.js as follows:

function getProblemNameWithId(problem_id) {
  var problem_id = parseInt(problem_id, 10);
  var problem = _.findWhere(problems, { "id": problem_id });
  if (problem == undefined) return "Deleted Problem(s)";
  return problem.name;
}

Before

After

[damianhxy]

lgtm!