Skip to content

Continue tidying pkg and code#306

Merged
bdewilde merged 18 commits into
masterfrom
continue-tidying-pkg-and-code
Aug 17, 2020
Merged

Continue tidying pkg and code#306
bdewilde merged 18 commits into
masterfrom
continue-tidying-pkg-and-code

Conversation

@bdewilde

@bdewilde bdewilde commented Aug 16, 2020

Copy link
Copy Markdown
Collaborator

Description

  • updates package configuration: adds a mypy config to reduce output noisiness, tightens up setup for finding packages
  • standardizes error messages on common error cases by way of a new errors.py top-level module
  • replaces string formatting with f-strings throughout most of the code base
  • parametrizes and updates many tests using pytest

Motivation and Context

Just continuing to clean out the cobwebs. textacy needed some love!

How Has This Been Tested?

All tests pass!

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation, and I have updated it accordingly.

@bdewilde bdewilde marked this pull request as ready for review August 17, 2020 01:01
@bdewilde bdewilde merged commit b79a297 into master Aug 17, 2020
@bdewilde bdewilde deleted the continue-tidying-pkg-and-code branch August 17, 2020 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant