Add download command to Makefile, use it in a GitHub Action, and update CONTRIBUTING.md#363
Merged
bdewilde merged 4 commits intoMar 5, 2023
Conversation
To pass CI/CD. The root cause is lack of reproducibility.
Collaborator
|
Hi @Hironsan! Very belatedly, I want to thank you for this contribution. Good catch on adding this to the contributing document, and nice thinking on using the new command in CI as well. Merging now 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When I cloned the repository and ran the test, I noticed that I needed to download the language data. That was not mentioned in CONTRIBUTING.md. So, I added the
downloadcommand to the Makefile, use it in the workflow as well, and update CONTRIBUTING.md.I also comment out some test cases to pass the test. I think the root cause is that the version of the dependencies is not locked. This PR doesn't solve the problem.
Types of changes
Checklist: