Skip to content

fix: scene culling light造成UBO无法对齐#19156

Open
Magnetismmy wants to merge 6 commits into
cocos:v3.8.8from
Magnetismmy:v3.8.8
Open

fix: scene culling light造成UBO无法对齐#19156
Magnetismmy wants to merge 6 commits into
cocos:v3.8.8from
Magnetismmy:v3.8.8

Conversation

@Magnetismmy

@Magnetismmy Magnetismmy commented Apr 2, 2026

Copy link
Copy Markdown

Re: #

Changelog

scene culling light造成UBO无法对齐,疑似C++原生端有相同问题未修改
*


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@github-actions

github-actions Bot commented Apr 2, 2026

Copy link
Copy Markdown

Code Size Check Report

Wechat (WASM) Before After Diff
2D Empty (legacy pipeline) 1009738 bytes 1009738 bytes ✅ 0 bytes
2D All (legacy pipeline) 2675347 bytes 2675347 bytes ✅ 0 bytes
2D All (new pipeline) 2767083 bytes 2768355 bytes ⚠️ +1272 bytes
(2D + 3D) All 10024081 bytes 10026560 bytes ⚠️ +2479 bytes
Web (WASM + ASMJS) Before After Diff
(2D + 3D) All 16843143 bytes 16845622 bytes ⚠️ +2479 bytes

Interface Check Report

This pull request does not change any public interfaces !

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@github-actions

Copy link
Copy Markdown

@Magnetismmy, Please check the result of run test cases:

Task Details

@github-actions

Copy link
Copy Markdown

@Magnetismmy, Please check the result of run test cases:

Task Details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant