Disable colors in Edge and Internet Explorer

[ibc]

Fixes #417

Both Internet Explorer and Edge report "AppleWebKit" in their User-Agent, so the current useColors() function in src/browser.js returns true (check my rationale about this here. But in fact, Edge and Internet Explorer do not support colors in the console.

This PR checks whether the browser is Edge/IE and, if so, makes useColors() return false.

NOTE: A good project for detecting browsers is bowser. In includes nice examples of how the User-Agent of many browsers looks like.

[ibc]

NOTE: I will be able to test my fork tomorrow Monday and will confirm here that it works (I hope).

[coveralls]

Coverage increased (+2.6%) to 75.325% when pulling 61852ef on ibc:disable-colors-in-edge-and-ie into 13e1d06 on visionmedia:master.

[coveralls]

Coverage increased (+2.6%) to 75.325% when pulling 0e47511 on ibc:disable-colors-in-edge-and-ie into 13e1d06 on visionmedia:master.

[coveralls]

Coverage increased (+2.6%) to 75.325% when pulling 0e47511 on ibc:disable-colors-in-edge-and-ie into 13e1d06 on visionmedia:master.

[coveralls]

Coverage increased (+2.6%) to 75.325% when pulling 0e47511 on ibc:disable-colors-in-edge-and-ie into 13e1d06 on visionmedia:master.

[ibc]

Hi, I'm just using my fork in Edge. It works. Obviously, the Edge support for %o in console.log("foo:%o", foo) is not very cool (it prints two lines, etc). But at least, with my PR logger() behaves similar to console.log() in Edge.

And we get rid of the ugly %ccheckEmail%c +0ms color: lightseagreen color stuff.

I hope you merge it.

[ibc]

Please authors, any feedback/comment about this PR?

debug module does not properly work in IE/Edge. This PR fixes that. Please, don't leave this PR open forever.

[TooTallNate]

Merged, thank you!

[ibc]

THANKS!!! Finally I can remove my debug fork from the package.json of many projects :)

[ibc]

Well, not so fast, I should wait for a new release in NPM :)

[TooTallNate]

Check v3.0.1

…

On Thu, Aug 24, 2017 at 12:42 PM, Iñaki Baz Castillo < ***@***.***> wrote: Well, not so fast, I should wait for a new release in NPM :) — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#489 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEWWBZ02LyE-1epPHXEnxmeHSjzwTViks5sbdIvgaJpZM4O8qne> .

[freewil]

Awesome, thanks! 👍

[ibc]

top top top!