Dataflow: Refactor dispatch with call context.#3804
Merged
Conversation
Contributor
Even though I agree with this, refactorings like these can sometimes make the QL evaluator reevaluate cached stages, so I think we should run Differences jobs just in case. |
hvitved
requested changes
Jun 26, 2020
hvitved
left a comment
hvitved
left a comment
Contributor
There was a problem hiding this comment.
Changes LGTM, but the C++ code no longer compiles. Also, as I wrote I think we should run performance comparisons to be safe.
Contributor
Author
Contributor
Author
|
Differences jobs show no performance changes as expected. |
hvitved
approved these changes
Jun 30, 2020
max-schaefer
pushed a commit
to max-schaefer/codeql-go
that referenced
this pull request
Jul 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be a clean refactor that doesn't change any behaviour or performance as it is simply moving some predicates around.
The upside of this refactor is that it reduces and simplifies the language-specific interface that's required for using call-context dependent virtual dispatch.