Add Bluetooth connection to Eurotronic Comet Blue devices#173670
Merged
joostlek merged 1 commit intoJun 13, 2026
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
Hey there @rikroe, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR adds Bluetooth connection information to the device registry entry for the Eurotronic Comet Blue integration and adds a test to verify the device registry entry.
Changes:
- Adds
connections={(dr.CONNECTION_BLUETOOTH, address)}to the device registry creation call in the integration setup. - Adds a new test file verifying the device registry entry includes the Bluetooth connection.
- Adds the corresponding snapshot file for the device registry test.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| homeassistant/components/eurotronic_cometblue/init.py | Adds Bluetooth connection to device registry entry creation |
| tests/components/eurotronic_cometblue/test_init.py | New test verifying device registry entry with Bluetooth connection |
| tests/components/eurotronic_cometblue/snapshots/test_init.ambr | Snapshot for the device registry test assertion |
rikroe
approved these changes
Jun 13, 2026
rikroe
left a comment
Contributor
There was a problem hiding this comment.
Thanks, wasn't aware of that! LGTM.
joostlek
approved these changes
Jun 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Register the Eurotronic Comet Blue device with its Bluetooth address as a
connection so the address is shown on the device page and other integrations can
attach to the same device.
Comet Blue devices were registered with only a domain identifier and no device
connections, so Home Assistant did not display the device's Bluetooth address,and other integrations that key off the Bluetooth connection (for example,
Bermuda BLE trilateration) ended up creating a separate device for the same
physical unit. Adding the
CONNECTION_BLUETOOTHconnection fixes both: theaddress now shows on the device page, and integrations referencing the same
Bluetooth device link to it instead of producing a duplicate.
The connection uses the same address (
entry.data[CONF_ADDRESS]) already used asthe device identifier, which is the Bluetooth address stored from discovery.
This is the same change applied to Aranet in #173066 and to AirVisual Pro in
#173071.
Please re-classify it as a Bugfix if deemed appropriate (as one could argue a
Bluetooth device should always carry its Bluetooth connection).
The change is covered by a new device-registry snapshot test that asserts the
Bluetooth connection is registered.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: