Fix QT_ARCH Apple Silicon build bug#3745
Draft
ann0see wants to merge 1 commit into
Draft
Conversation
ann0see
force-pushed
the
macOS/fixASBuild
branch
from
f29b215 to
15ddc58
Compare
ann0see
force-pushed
the
macOS/fixASBuild
branch
from
15ddc58 to
6d6e6a5
Compare
ann0see
commented
Jun 19, 2026
| libs/opus/silk/x86/VQ_WMat_EC_sse4_1.c | ||
|
|
||
| contains(QT_ARCH, armeabi-v7a) | contains(QT_ARCH, arm64-v8a) { | ||
| contains(QT_ARCH, armeabi-v7a) | contains(QT_ARCH, arm64-v8a) | contains(QT_ARCH, arm64) { |
Member
Author
There was a problem hiding this comment.
Will potentially enable vectorisation on arm64 devices.
ann0see
commented
Jun 19, 2026
| DEFINES_OPUS += OPUS_BUILD=1 USE_ALLOCA=1 OPUS_HAVE_RTCD=1 HAVE_LRINTF=1 HAVE_LRINT=1 | ||
| DEFINES_OPUS += OPUS_BUILD=1 USE_ALLOCA=1 HAVE_LRINTF=1 HAVE_LRINT=1 | ||
|
|
||
| !macx | !contains(QT_ARCH, x86_64) { |
Member
Author
There was a problem hiding this comment.
I would hope that there is some variable which is definitely arm64 on apple silicon and x86 on intel... Then we could probably use it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
Removes opus optimizations on macOS to allow building on M series chips. This is very hacky and needs some more discussion. The CI seems to build differently - and it works without this fix. Local builds however fail as the QT_ARCH variable does not contain arm64 even if compiling on arm64.
CHANGELOG: Fix build on macOS (Apple Silicon)
Context: Fixes an issue?
Does this change need documentation? What needs to be documented and how?
Status of this Pull Request
Ready for review and discussion.
What is missing until this pull request can be merged?
Checklist
AUTOBUILD: Please build all targets