fix:typescript: set default export#18
Merged
Merged
Conversation
javascript use `module.exports = function (opts) {` which is equivalent to default export in typescript; infact keypair is not exported as named export in javascript.
Owner
|
Thanks for the explanation 🙌 https://github.com/juliangruber/keypair/releases/tag/v1.0.3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
javascript use
module.exports = function (opts) {which is equivalent to default export in typescript;-keypair is not exported as named export in javascript
in typescript if lib. is imported using:
import {keypair} form 'keypair'}which cause "keypair.keypair is not a function" errorimport * as keypair from 'keypair'will throw typescript error; keypair is not a functionimport keypair from 'keypair';will result in 'keypair doesnot have default export' error;this pull request export keypair as default export; i kept named export as is in case it was placed there for a future reason!