Skip to content

feat: more shopping list enhancements#2587

Merged
hay-kot merged 15 commits into
mealie-recipes:mealie-nextfrom
michael-genson:feat/shopping-list-enhancements
Oct 7, 2023
Merged

feat: more shopping list enhancements#2587
hay-kot merged 15 commits into
mealie-recipes:mealie-nextfrom
michael-genson:feat/shopping-list-enhancements

Conversation

@michael-genson

Copy link
Copy Markdown
Collaborator

What type of PR is this?

(REQUIRED)

  • bug
  • feature

What this PR does / why we need it:

(REQUIRED)

A bunch of enhancements to the shopping list:

  • fixed some visual bugs
  • fixed random list item re-ordering nonsense and made it consistent

And I added a task that purges old, checked-off shopping list items over a threshold (currently set to 100). I have a feeling a lot of users don't know how big their "checked-off" list gets, which eventually bogs down the shopping list.

Which issue(s) this PR fixes:

(REQUIRED)

N/A

Testing

(fill-in or delete this section)

Pytest for the new task

Release Notes

(REQUIRED)

fixed some visual shopping list bugs
fixed shopping list items re-arranging themselves in certain instances
automatically delete older checked-off shopping list items when there are more than 100 of them

@michael-genson michael-genson force-pushed the feat/shopping-list-enhancements branch from 19eb723 to 369c6f5 Compare September 29, 2023 19:17
Comment thread frontend/pages/shopping-lists/_id.vue Outdated
@michael-genson

Copy link
Copy Markdown
Collaborator Author

I think I did the reduce right? Pretty sure it works

@hay-kot hay-kot merged commit b153ddf into mealie-recipes:mealie-next Oct 7, 2023
@michael-genson michael-genson deleted the feat/shopping-list-enhancements branch October 7, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants