Skip to content

Allow limiting the maximum number of turns in initiate_chat and initiate_chats#1703

Merged
sonichi merged 7 commits into
mainfrom
turn-number
Feb 17, 2024
Merged

Allow limiting the maximum number of turns in initiate_chat and initiate_chats#1703
sonichi merged 7 commits into
mainfrom
turn-number

Conversation

@qingyun-wu

Copy link
Copy Markdown
Contributor

Why are these changes needed?

This PR adds an argument in initiate_chat to allow users to limit the maximum number of conversation turns

Related issue number

Checks

@codecov-commenter

codecov-commenter commented Feb 16, 2024

Copy link
Copy Markdown

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (bf3cc0f) 39.62% compared to head (9fbfacb) 58.42%.

Files Patch % Lines
autogen/agentchat/conversable_agent.py 84.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1703       +/-   ##
===========================================
+ Coverage   39.62%   58.42%   +18.79%     
===========================================
  Files          57       57               
  Lines        6006     6020       +14     
  Branches     1338     1464      +126     
===========================================
+ Hits         2380     3517     +1137     
+ Misses       3433     2222     -1211     
- Partials      193      281       +88     
Flag Coverage Δ
unittests 58.40% <85.71%> (+18.77%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread autogen/agentchat/chat.py
Comment thread test/agentchat/test_conversable_agent.py Outdated
Comment thread autogen/agentchat/conversable_agent.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants