Add ModuleKindNode18#163
Closed
andrewbranch wants to merge 1 commit into
Closed
Conversation
Member
|
My impressive was that we were porting up to the pinned commit in the submodule; are we wanting to take this now? |
Member
|
If we are taking this, could you also update |
Member
Author
|
When are we moving the pin? I’ve already included a fix in module resolution that I found due to porting. |
Member
|
I'm not sure... I was assuming we were aiming for full checker completeness before then, so we can hand backport each change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Counterpart to microsoft/TypeScript#60722