fix: [cp2.6] support CPU adaptation for GPU CAGRA loading (#50096)#50385
Open
marcelo-cjl wants to merge 1 commit into
Open
fix: [cp2.6] support CPU adaptation for GPU CAGRA loading (#50096)#50385marcelo-cjl wants to merge 1 commit into
marcelo-cjl wants to merge 1 commit into
Conversation
mergify
Bot
added
dco-passed
Contributor
|
[ci-v2-notice] To rerun ci-v2 checks, comment with:
If you have any questions or requests, please contact @zhikunyao. |
sre-ci-robot
added
the
do-not-merge/need-merge-master-first
Contributor
|
[INFO] PR Label Summary by Default
Use /refresh-label to update related check and label manually |
marcelo-cjl
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.6 #50385 +/- ##
==========================================
+ Coverage 76.99% 77.73% +0.74%
==========================================
Files 1700 1999 +299
Lines 262533 329117 +66584
==========================================
+ Hits 202142 255846 +53704
- Misses 53550 65428 +11878
- Partials 6841 7843 +1002
🚀 New features to boost your workflow:
|
sre-ci-robot
added
the
low-code-coverage
Signed-off-by: marcelo-cjl <marcelo.chen@zilliz.com> (cherry picked from commit 22f5f9b) Signed-off-by: marcelo-cjl <marcelo.chen@zilliz.com>
marcelo-cjl
force-pushed
the
cherrypick-50096-2.6
branch
from
62ce95a to
b65eef6
Compare
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: marcelo-cjl The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/refresh-label |
sre-ci-robot
removed
the
do-not-merge/need-merge-master-first
Contributor
|
[INFO] PR Label Summary by Refresh-Label
[SUCCESS] PR #50096 merged to master
Use /refresh-label to update related check and label manually |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick from master
pr: #50096
issue: #49836
Summary
adapt_for_cpuenabled as CPU-adapted in QueryNode resource checks.Test plan
git diff --check upstream/2.6..HEADGO_DIFF_FILES="internal/datanode/index_services_test.go internal/querynodev2/segments/collection.go internal/querynodev2/segments/collection_test.go internal/querynodev2/segments/segment_loader.go internal/querynodev2/segments/segment_loader_test.go" make fmtgo test -count=1 -tags test ./internal/querynodev2/segments -run 'TestGpuIndexRequiresGpu|TestCollectionManagerSuite/TestGpuIndexFlagWithCagraAdaptForCPU'blocked locally because this clean 2.6 workspace has not builtinternal/core/output/lib/libmilvus_core.so.