impr(input-indicator): add input indicator to all fields with validators (@Leonabcd123)#7918
Merged
Merged
Conversation
Leonabcd123
changed the title
Member
|
I havent tested this yet, but maybe we could remove the It is kind of odd to define validations on a field but don't want to show the indicator for it |
Leonabcd123
changed the title
fehmer
approved these changes
May 11, 2026
Member
|
Thanks |
Miodec
pushed a commit
that referenced
this pull request
May 19, 2026
### Regression Commit 0c07e10 (PR #7918) removed the `showIndicator` prop from InputField and switched to `props.field().options.validators` as the "Gate" to show/hide FieldIndicator, but didn't update InputField.stories.tsx. The story's field mock was missing options, causing props.field().options throw error ### Fix Added options: { validators } support to createFieldMock, updated withIndicator to pass a dummy validator, and removed the dead showIndicator prop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the
showIndicatorproperty fromInputField, instead check whethervalidatorsexists to decide whether we should show the input indicator.