Skip to content

chore: move to JSON#237

Open
avivkeller wants to merge 2 commits into
mainfrom
json
Open

chore: move to JSON#237
avivkeller wants to merge 2 commits into
mainfrom
json

Conversation

@avivkeller

Copy link
Copy Markdown
Member

Also supersedes #236, and fixes the issue mentioned in that PRs description.

Comment thread src/meeting.mjs
export const generateMeetingAgenda = agendaIssues => {
// Format issues as markdown
let agendaMarkdown = '';
const escapeTitle = title => title.replace(/([[\]])/g, '\\$1');

@aduh95 aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a lot of changes to review, could you give more details on how you generate them and what to review?

@avivkeller

Copy link
Copy Markdown
Member Author

This moves the dotenv files to .json files, so that they are easier to edit, as we've gotten concerns that editting the dotenv files is tedious and annoying. The files should contain the same content as the dotenv, so just verifying that they do / that they can be read properly is all that needs to be reviewed, though I have tested this on my own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants