Skip to content
This repository was archived by the owner on Apr 22, 2023. It is now read-only.

crypto, zlib: change _binding to _handle for consistency#7536

Closed
seishun wants to merge 1 commit into
nodejs:masterfrom
seishun:_handle-everywhere
Closed

crypto, zlib: change _binding to _handle for consistency#7536
seishun wants to merge 1 commit into
nodejs:masterfrom
seishun:_handle-everywhere

Conversation

@seishun

@seishun seishun commented Apr 30, 2014

Copy link
Copy Markdown

As mentioned in #7372, replacing all instances of _binding with _handle for consistency with the rest of node's internal code.

@Nodejs-Jenkins

Copy link
Copy Markdown

Thank you for contributing this pull request! Here are a few pointers to make sure your submission will be considered for inclusion.

Commit seishun/node@aeff00d1bcac3d4dab2cfdc244a77b2c1d975cee has the following error(s):

  • First line of commit message must be no longer than 50 characters

The following commiters were not found in the CLA:

  • seishun

You can fix all these things without opening another issue.

Please see CONTRIBUTING.md for more information

@indutny

indutny commented May 2, 2014

Copy link
Copy Markdown
Member

cc @tjfontaine , that's on your field

@trevnorris trevnorris added the zlib label May 7, 2014
@trevnorris

Copy link
Copy Markdown

Going to say this is OK. Using _handle is the convention for any objects that have a C++ class counterpart that can be extracted using Unwrap<T>().

@tjfontaine Anything I'm missing?

@tjfontaine

Copy link
Copy Markdown

Yup, LGTM

@trevnorris

Copy link
Copy Markdown

Thanks. Merged in 5344d0c.

@trevnorris trevnorris closed this May 7, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants