Skip to content

Update webstreams.md#47762

Closed
christiantakle wants to merge 1 commit into
nodejs:mainfrom
christiantakle:patch-1
Closed

Update webstreams.md#47762
christiantakle wants to merge 1 commit into
nodejs:mainfrom
christiantakle:patch-1

Conversation

@christiantakle

@christiantakle christiantakle commented Apr 28, 2023

Copy link
Copy Markdown
Contributor

doc: fix arrayBuffer alias typo

buffer was aliased to arrayBuffer in an example for arrayBuffer.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 28, 2023

@debadree25 debadree25 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
could you just update your commit message according to the guidelines https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#commit-message-guidelines

Thanks!

@christiantakle

Copy link
Copy Markdown
Contributor Author

Haha knew something like this would happen.

git clone git@github.com:christiantakle/node.git --depth=1 --branch=patch-1
# rename commit with lazygit
git push --force-with-lease

Meh will have to recreate.

@debadree25

Copy link
Copy Markdown
Contributor

ah i think git push -f would have been fine somehow --force-with-lease closes the PR I think? interesting

@christiantakle

Copy link
Copy Markdown
Contributor Author

Interesting indeed :D

@christiantakle

christiantakle commented Apr 28, 2023

Copy link
Copy Markdown
Contributor Author

Cloned pr #47766

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants