fs: runtime deprecate fs.F_OK, fs.R_OK, fs.W_OK, fs.X_OK

[LiviaMedeiros]

Follow-up from: #49683 (doc-only deprecation)

Opening this ahead of time to point out that the getters here are non-enumerable.

cc @nodejs/fs

[richardlau]

Given that we've only just doc-deprecated these #49683 (not in a release yet) I think it would be premature to runtime deprecate in Node.js 21. I'd have no objections to runtime deprecation in Node.js 22.

[LiviaMedeiros]

Sure; converting back to draft until v21.x is released.

The main point of opening it now was to see if there are any objections or suggestions to the implementation.
If we keep the getters with enumerable: true, the deprecation warning will be indirectly triggered by child_process; I don't know if there is any better workaround.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/57454/

[juanarbol]

@LiviaMedeiros this may needs rebase, this is a good timing for v24.x I think (?)

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/63401/

[LiviaMedeiros]

Rebased on main.

cc @nodejs/tsc since it's semver-major PRs that contain breaking changes and should be released in the next major version.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.40%. Comparing base (c2ff449) to head (7000c66).
Report is 74 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #49686      +/-   ##
==========================================
- Coverage   88.41%   88.40%   -0.02%     
==========================================
  Files         654      654              
  Lines      187594   187696     +102     
  Branches    36090    36114      +24     
==========================================
+ Hits       165870   165936      +66     
- Misses      14980    14996      +16     
- Partials     6744     6764      +20     

Files with missing lines	Coverage Δ
lib/fs.js	98.26% <100.00%> (+0.11%)	⬆️

... and 34 files with indirect coverage changes

[aduh95]

CITGM (main): https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3499/
CITGM (this PR): https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3500/

No related failure AFAICT

[nodejs-github-bot]

Landed in b02cd41