src: add UV_PIPE_NO_TRUNCATE for bind in pipe_wrap.cc#52347
Merged
nodejs-github-bot merged 1 commit intoMay 6, 2024
Conversation
f2d4433 to
92f36e7
Compare
Collaborator
92f36e7 to
85adc9e
Compare
VoltrexKeyva
reviewed
Apr 3, 2024
85adc9e to
fb5aa12
Compare
Collaborator
Collaborator
daeyeon
approved these changes
Apr 19, 2024
daeyeon
left a comment
Member
There was a problem hiding this comment.
Yes, this is definitely a breaking change. As suggested, I think it would be better to throw an error in this case to make users aware of potential problems.
Collaborator
fb5aa12 to
d798da4
Compare
jasnell
approved these changes
Apr 21, 2024
Collaborator
Collaborator
Member
|
@nodejs/tsc ... this needs another TSC review. |
benjamingr
approved these changes
Apr 28, 2024
mcollina
requested changes
Apr 28, 2024
mcollina
left a comment
Member
There was a problem hiding this comment.
Thanks for opening a PR! Can you please add a unit test?
Member
|
There was a test, but it seems to be accidentally deleted. Please add it again. |
d798da4 to
c3901ad
Compare
ShogunPanda
approved these changes
May 2, 2024
c3901ad to
4e06896
Compare
anonrig
approved these changes
May 3, 2024
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
|
Landed in 7588467 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Binding a pipe path that is too long can cause problems and confuse the user.
example1:
example2:
I think it is better to throw an error when the pipe path is truncated. But it maybe a breaking change.
make -j4 test(UNIX), orvcbuild test(Windows) passes