util: reduce TextEncoder.encodeInto function size

[anonrig]

<SharedFunctionInfo encodeInto>}: big function, size (117) >= max-size (100)

It seems encodeInto function is too big to inline with v8. This is an attempt to reduce the size of the function by eliminating validateEncoder() calls, and replacing them with private attribute calls.

This is a semver-major because it changes the errors thrown if this is different.

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1743/

[anonrig]

cc @nodejs/tsc due to semver-major

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.59%. Comparing base (94cbb77) to head (ef0b9c2).
⚠️ Report is 22 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #60339      +/-   ##
==========================================
- Coverage   92.20%   88.59%   -3.62%     
==========================================
  Files         345      704     +359     
  Lines      138924   208473   +69549     
  Branches    22203    40066   +17863     
==========================================
+ Hits       128094   184691   +56597     
- Misses      10601    15798    +5197     
- Partials      229     7984    +7755     

Files with missing lines	Coverage Δ
lib/internal/encoding.js	99.51% <100.00%> (+18.06%)	⬆️

... and 476 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[ljharb]

should the same changes be made for TextDecoder?

[anonrig]

should the same changes be made for TextDecoder?

Yes, I'll open a separate pull-request for TextDecoder.

[joyeecheung]

LGTM, I always feel that ERR_INVALID_THIS isn't a super useful specialized error as usually that just indicates that there's a bug in your program and it should be fixed; there isn't really much of a point to catch it and try again (how is one supposed to retry, anyway?)

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/69846/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/69849/

[nodejs-github-bot]

Landed in ddbe136