Skip to content

Configuration file for Crowdin integration#2344

Merged
zeke merged 3 commits into
nodejs:masterfrom
Andrulko:master
Jul 23, 2019
Merged

Configuration file for Crowdin integration#2344
zeke merged 3 commits into
nodejs:masterfrom
Andrulko:master

Conversation

@Andrulko

Copy link
Copy Markdown
Contributor

You already have translations for Markdown files, so importing .md files with content_segmentation: 0 is a good idea, it will segment content by paragraphs and integration will automatically import existing translations to Crowdin (e.g. 1st paragraph in translated file is imported to the 1st paragraph in the source file).

A bit customized language codes are used for Portuguese, Brazilian and Chinese, thus languages mapping was added to fit your current folder names (e.g. pt-br).

Hope it helps to start faster!

@alexandrtovmach

Copy link
Copy Markdown
Contributor

@Andrulko Amazing, that's really helpful. Will start working on it shortly

@Trott

Trott commented Jul 23, 2019

Copy link
Copy Markdown
Member

I don't understand how CrowdIn works exactly, so I'm disinclined to review this myself, but it would be great if we could get some reviews and get it landed (or closed if it's not something we want to land, but I suspect we do). @nodejs/website

@zeke zeke left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @Andrulko 👍

@aymen94

aymen94 commented Jul 23, 2019

Copy link
Copy Markdown
Member

LGTM. Thanks for contribution @Andrulko 😃

@alexandrtovmach

Copy link
Copy Markdown
Contributor

Sure, I have very busy week now, so haven't enough time for that. Will check it

@zeke zeke merged commit 6357c0d into nodejs:master Jul 23, 2019
@nschonni

Copy link
Copy Markdown
Member

Should content start showing up on https://crowdin.com/project/nodejs or are there further steps required for this to work?

@Trott

Trott commented Sep 17, 2019

Copy link
Copy Markdown
Member

Should content start showing up on https://crowdin.com/project/nodejs or are there further steps required for this to work?

/ping @nodejs/i18n

@zeke

zeke commented Sep 17, 2019

Copy link
Copy Markdown
Contributor

Yes. There's content now at https://crowdin.com/project/nodejs that's ready to be translated. At present it's necessary for someone to manually update the source English content by running a script: https://github.com/nodejs/i18n/blob/96e86dd8177975e104aac2151026d194f690093d/package.json#L19

The script downloads docs for the Node.js versions specified here: https://github.com/nodejs/i18n/blob/96e86dd8177975e104aac2151026d194f690093d/package.json#L5-L9

Whenever the master branch of nodejs/i18n is updated, Crowdin automatically imports those changes into the https://crowdin.com/project/nodejs project. That's configured here: https://github.com/nodejs/i18n/blob/96e86dd8177975e104aac2151026d194f690093d/crowdin.yml

It looks like @alexandrtovmach updated this content 2 months ago in nodejs/i18n#199 so the content in Crowdin is relatively up to date.

@nschonni

Copy link
Copy Markdown
Member

Looks like the i18n repo stuff is for the nodejs/node API translations. Looks like Crowdin might need a seperate project to point to this repo and content

@nschonni

nschonni commented Sep 18, 2019

Copy link
Copy Markdown
Member

Oh, maybe it's this one https://crowdin.com/project/nodejs-website, but there is no content in that project

@alexandrtovmach

Copy link
Copy Markdown
Contributor

@nschonni I'm working on it

@zeke

zeke commented Sep 18, 2019

Copy link
Copy Markdown
Contributor

Oh sorry I misread your earlier comment @nschonni. There are indeed two projects in Crowdin. We are hoping to be able to share user permissions, Translation Memory, etc across the two.

@nschonni

Copy link
Copy Markdown
Member

Cool, I wondering if it will figure out the already translated stuff once https://support.crowdin.com/github-integration/ is setup
#2510 might also be needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants