This repository was archived by the owner on Aug 11, 2020. It is now read-only.
quic: more test fixups#335
Closed
jasnell wants to merge 16 commits into
Closed
Conversation
36 tasks
Using promises syntax as an additional check that the promises support works.
addaleax
reviewed
Feb 8, 2020
addaleax
left a comment
addaleax
left a comment
Member
There was a problem hiding this comment.
LGTM, basically only have the same two comments for a number of files :) The .then(common.mustCall()) is something we should definitely have.
Co-Authored-By: Anna Henningsen <github@addaleax.net>
addaleax
approved these changes
Feb 10, 2020
jasnell
added a commit
that referenced
this pull request
Feb 10, 2020
PR-URL: #335 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Member
Author
|
Landed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.