refactor: for readability#130
Closed
jjangga0214 wants to merge 1 commit into
Closed
Conversation
aeschright
reviewed
Jan 7, 2019
aeschright
left a comment
Contributor
There was a problem hiding this comment.
We're going to reject this because there's an open patch on the same part of the code and it will cause conflicts. I appreciate your interest in working on the readability of the code -- feel free to look for places that in-progress work can be improved!
Ref: #61
This was referenced May 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
\nor a special character like→for example) from what users actually see.Therefore I refactored a little.