Skip to content

Remove readable-stream dependency#67

Closed
pravi wants to merge 1 commit into
npm:latestfrom
pravi:patch-1
Closed

Remove readable-stream dependency#67
pravi wants to merge 1 commit into
npm:latestfrom
pravi:patch-1

Conversation

@pravi

@pravi pravi commented Sep 12, 2018

Copy link
Copy Markdown

as require("stream") can be used and readable-stream is no longer used.

as require("stream") can be used and readable-stream is no longer used.
@pravi pravi requested a review from a team as a code owner September 12, 2018 17:29
@kenany

kenany commented Sep 12, 2018

Copy link
Copy Markdown
Contributor

Previously: npm/npm#17528

@jmannanc

Copy link
Copy Markdown
Contributor

It's a little bit more complex then that, see #59 for more details

@pravi

pravi commented Sep 21, 2018

Copy link
Copy Markdown
Author

@sneakyfish5 thanks for the heads up. How about we try to remove readable-stream from all dependencies? I did that in debian already.

@jmannanc

Copy link
Copy Markdown
Contributor

@pravi Some of the deps might break without their specific version of readable-stream though. If you've done it already and it works though, definitely give it a shot.

@zkat

zkat commented Nov 13, 2018

Copy link
Copy Markdown
Contributor

We use readable-stream as a direct dependency to stabilize its version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants