Phase 4: Refactor session/shortcode/comment helpers to remove helper ivars#1179
Merged
Merged
Conversation
- Refactor session, shortcode, and comment helpers to remove helper ivars - Move shortcode/session request state to CurrentRequest attributes - Keep compatibility for controller @user and shortcode admin listing behavior - Add helper specs for session and comment helpers - Remove Phase 4 Rails/HelperInstanceVariable exclusions from rubocop todo - Add durable docs/ai plan structure, including release-scoped plans Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
[skip ci] Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
[skip ci] Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and Why
This completes Phase 4 of the helper ivar cleanup stream by removing remaining helper instance-variable state from session_helper, short_code_helper, and comment_helper, while preserving behavior through request-scoped CurrentRequest state and compatibility fallbacks where controllers/views still expect legacy context.
It also finalizes Phase 4 governance updates by removing corresponding Rails/HelperInstanceVariable exclusions and introducing durable in-repo planning docs under docs/ai/plans (including release-scoped plans).
User-Visible Impact
No intentional user-facing behavior change; this is primarily internal refactoring and reliability hardening with existing flows preserved.