Security: Prevent account takeover via users#updated_ajax by unifying target-user lookup and authorization#1185
Merged
Conversation
…ller#updated_ajax Co-authored-by: Junie <junie@jetbrains.com>
texpert
changed the title
… and thanks [skip ci] Co-authored-by: Junie <junie@jetbrains.com>
texpert
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Admin::UsersController#updated_ajaxby resolving the target user from a single canonical param (user_id_param) in bothvalidate_roleand the action, so authorization is applied to the actual record being modified.Changes
user_id_paramconsistently invalidate_roleandupdated_ajax.Impact
Acknowledgements