Skip to content

Upgrade swagger ui to 3.48.0#316

Merged
j5awry merged 1 commit into
python-restx:masterfrom
xuhdev:upgrade-swagger-ui
May 27, 2021
Merged

Upgrade swagger ui to 3.48.0#316
j5awry merged 1 commit into
python-restx:masterfrom
xuhdev:upgrade-swagger-ui

Conversation

@xuhdev

@xuhdev xuhdev commented May 18, 2021

Copy link
Copy Markdown
Contributor

Close #300

@xuhdev xuhdev force-pushed the upgrade-swagger-ui branch from 28944d9 to 1c70816 Compare May 18, 2021 19:01
@xuhdev xuhdev marked this pull request as ready for review May 18, 2021 22:54
@xuhdev

xuhdev commented May 18, 2021

Copy link
Copy Markdown
Contributor Author

I have verified that this upgrade works and solves #300.

@j5awry

j5awry commented May 19, 2021

Copy link
Copy Markdown
Contributor

@physikerwelt would you have the ability to test his proposed fix for #300?

@xuhdev

xuhdev commented May 22, 2021

Copy link
Copy Markdown
Contributor Author

@physikerwelt Would you mind testing it out :)

@xuhdev

xuhdev commented May 24, 2021

Copy link
Copy Markdown
Contributor Author

Could you help review and consider merging it, please? We are also waiting for the fix on our side and would like to avoid using a fork if possible. Thanks!

@physikerwelt

Copy link
Copy Markdown
Contributor

Yes, I can certainly test it. I am not exactly sure how, but I will figure it out.

@physikerwelt

Copy link
Copy Markdown
Contributor

It works nicely with
http://127.0.0.1:5000/?tryItOutEnabled=true
Is there any way to enable this option permanently on the server side?

@physikerwelt

Copy link
Copy Markdown
Contributor

Yes, I can certainly test it. I am not exactly sure how, but I will figure it out.

Thanks to @ziirish I manged to test it. Thank you.

@codecov

codecov Bot commented May 26, 2021

Copy link
Copy Markdown

Codecov Report

Merging #316 (1c70816) into master (a39e06f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #316   +/-   ##
=======================================
  Coverage   96.81%   96.81%           
=======================================
  Files          20       20           
  Lines        2730     2730           
=======================================
  Hits         2643     2643           
  Misses         87       87           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a39e06f...1c70816. Read the comment docs.

@xuhdev

xuhdev commented May 26, 2021

Copy link
Copy Markdown
Contributor Author

Thanks @physikerwelt ! You should be able to enable it by default by configuring it in swagger-config.yaml or environment variables: https://swagger.io/docs/open-source-tools/swagger-ui/usage/configuration/

@j5awry j5awry merged commit f74c9ad into python-restx:master May 27, 2021
@xuhdev xuhdev deleted the upgrade-swagger-ui branch May 27, 2021 18:01
@xuhdev

xuhdev commented May 27, 2021

Copy link
Copy Markdown
Contributor Author

Could you make a new release :) Thanks!

@xuhdev

xuhdev commented Jun 3, 2021

Copy link
Copy Markdown
Contributor Author

Could you make a new release for this PR? Installing from the git repo won't get the new swagger UI version :( Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tryItOutEnabled

3 participants