Skip to content

Removes I/O dependency at StreamSelectLoopTest to fix Mac OS X tests#161

Merged
WyriHaximus merged 1 commit into
reactphp:masterfrom
nawarian:fix_stream_select_loop_test
Apr 24, 2018
Merged

Removes I/O dependency at StreamSelectLoopTest to fix Mac OS X tests#161
WyriHaximus merged 1 commit into
reactphp:masterfrom
nawarian:fix_stream_select_loop_test

Conversation

@nawarian

@nawarian nawarian commented Apr 9, 2018

Copy link
Copy Markdown
Contributor

@WyriHaximus WyriHaximus requested review from WyriHaximus, clue and jsor April 9, 2018 15:31
@WyriHaximus WyriHaximus added this to the v0.5.2 milestone Apr 9, 2018
@clue clue changed the title Removes I/O dependency at StreamSelectLoopTest Removes I/O dependency at StreamSelectLoopTest to fix Mac OS X tests Apr 24, 2018

@clue clue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for filing this PR! :shipit:

@clue clue added bug and removed help wanted labels Apr 24, 2018

@WyriHaximus WyriHaximus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@WyriHaximus WyriHaximus merged commit 945205d into reactphp:master Apr 24, 2018
@nawarian nawarian deleted the fix_stream_select_loop_test branch April 24, 2018 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants