Skip to content

ResumableParser#partial_value avoid mutating the stacks #1007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
byroot merged 1 commit into from
Jun 15, 2026
+17 −0
Merged

ResumableParser#partial_value avoid mutating the stacks #1007

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ext/json/ext/parser/parser.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2496,6 +2496,9 @@ static VALUE cResumableParser_partial_value(VALUE self)
JSON_ResumableParser *original_parser = ResumableParser_acquire(self, false);
JSON_ResumableParser parser = *original_parser;

parser.state.frames = &parser.frames;
parser.state.value_stack = &parser.value_stack;

if (parser.value_stack.head == 0) {
return Qnil;
}
Expand Down
14 changes: 14 additions & 0 deletions test/json/resumable_parser_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,20 @@ def test_partial_value
assert_partial_value([1, { "a" => 1, "b" => { "c" => nil } }], '[1, { "a": 1, "b": { "c"')
end

def test_partial_value_issue_1005
data = <<~JSON
[
[]
]
JSON
data.each_line do |line|
@parser << line
@parser.parse
@parser.partial_value # This unexpected parse error doesn't happen if we comment this out
end
assert_equal [[]], @parser.value
end

def test_partial_value_missing
assert_nil @parser.partial_value
end
Expand Down
Loading