fix: abort non-retryable Klaviyo upload errors instead of retrying#7085
Open
shekhar-rudder wants to merge 1 commit into
Open
fix: abort non-retryable Klaviyo upload errors instead of retrying#7085shekhar-rudder wants to merge 1 commit into
shekhar-rudder wants to merge 1 commit into
Conversation
shekhar-rudder
force-pushed
the
fix/INT-6539-klaviyo-abort-non-retryable-errors
branch
from
be160f6 to
97b3ba5
Compare
shekhar-rudder
requested review from
ItsSudip and
achettyiitr
and removed request for
ItsSudip
…NT-6539) Klaviyo 4xx errors (except 429) were incorrectly marked as retryable, causing invalid profiles to retry indefinitely, fill batch slots, and push valid events into "prescribed limit" overflow until they were permanently aborted. Now 4xx (except 429) errors are routed to AbortJobIDs, while 429/5xx and network errors remain in FailedJobIDs for retry. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
shekhar-rudder
force-pushed
the
fix/INT-6539-klaviyo-abort-non-retryable-errors
branch
from
97b3ba5 to
e22441f
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7085 +/- ##
==========================================
+ Coverage 79.88% 79.92% +0.04%
==========================================
Files 583 583
Lines 65088 65099 +11
==========================================
+ Hits 51993 52031 +38
+ Misses 10001 9970 -31
- Partials 3094 3098 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FailedJobIDs), causing invalid profiles to retry indefinitely, fill batch slots, and push valid events into "prescribed limit" overflow until they were permanently abortedUploadProfilesnow captures the HTTP status code from Klaviyo's responseUploadroutes errors by retryability: 4xx (except 429) →AbortJobIDs(terminal), 429/5xx/network errors →FailedJobIDs(retryable)FailedReasonis now populated in the upload output for better observabilityTest plan
TestUpload/Successful_Upload— all jobs import successfully, no failuresTestUpload/Unsuccessful_Upload— nil response (network error) → jobs retried withFailedReasonTestUpload/UploadThreeChunksWithMixedFailures— chunk 1 gets 429 (retried), chunk 2 gets 400 (aborted), chunk 3 succeeds — validates both paths in single testLinear ticket
INT-6539
🤖 Generated with Claude Code